Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vercel blog starter to examples #86

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Add vercel blog starter to examples #86

merged 3 commits into from
Oct 12, 2024
+1,996 −0

Conversation

shashankboosi
Copy link
Contributor

@shashankboosi shashankboosi commented Oct 10, 2024 •
edited
Loading

Added the vercel blog starter to examples as a way to test applications. I used this from vercel which wasn't working but fixed it to the needs of the adapter

You can run the new example using pnpm --filter vercel-blog-starter preview:worker

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: deccf66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vicb
vicb reviewed Oct 10, 2024
View reviewed changes
pnpm-lock.yaml Show resolved Hide resolved
@vicb
Copy link
Contributor

vicb commented Oct 10, 2024

I used this from vercel which wasn't working but fixed it to the needs of the adapter

One thing you can do is two separate commit:

  • first commit would be "import blog start at "
  • second commit would be "adapt for cloudflare worker"

It's nice to have the required changes in the history

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 10, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@86

commit: deccf66

@vicb vicb mentioned this pull request Oct 11, 2024
Closed
@shashankboosi
Copy link
Contributor Author

Made all the recommended changes and had the commits in the flow, that is nice to read

@shashankboosi shashankboosi reopened this Oct 12, 2024
@shashankboosi
Copy link
Contributor Author

shashankboosi commented Oct 12, 2024 •
edited
Loading

I had to delete the commit where I remove pnpm-lock because currently there is no way to run github actions without a lock file(they all will fail) and there is an open issue about it here.

Maybe if you want, I can investigate it as a separate issue

@vicb
Copy link
Contributor

vicb commented Oct 12, 2024

I had to delete the commit where I remove pnpm-lock

My bad, it should not be removed.
I was looking at the changes too qhuickly and thought it was nested in the blog folder.
The root lock file should not be removed.

vicb
vicb requested changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much!

2 things:

  • could you please add a patch changeset
  • it would be nice to add a basic e2e test, you can check i.e. the API example. If you are willing to do this, you can do it in a follow up PR when you have time. No rush.

@shashankboosi
Copy link
Contributor Author

@vicb I have added the changeset. In regards to adding an e2e test, I will do it in another PR as I don't want to keep holding this one :)

@shashankboosi @vicb
Add the vercel blog-starter example
ea4b649 
Created using `pnpm create next-app --example blog-starter vercel-blog-starter`
@shashankboosi @vicb
Fix the code
c1578b6 
using pnpm `pnpm run code:fixes`
@shashankboosi @vicb
Adapt the blog starter to cloudflare workers
deccf66
@vicb
Copy link
Contributor

vicb commented Oct 12, 2024

I don't want to keep holding this one :)

Yep, makes sense.

Thank for adding the example!

@vicb vicb merged commit 5bceecc into opennextjs:main Oct 12, 2024
7 checks passed
@shashankboosi shashankboosi deleted the vercel-blog-example branch October 12, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashankboosi @vicb